chore: loops clean up #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Oct 1, 2023
Comment on lines
-60
to
-61
| cpy.limbs.iter_mut().for_each(|limb| limb.reverse_bits()); | ||
| slice::from_raw_parts(cpy.limbs.as_ptr().cast(), Self::BYTES).to_vec() |
There was a problem hiding this comment.
This didn't compile, also can't make the function const.
DaniPopes
force-pushed
the
simpler-loops
branch
from
0aa471c
to
7e13383
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
- Coverage 80.52% 80.47% -0.06%
==========================================
Files 54 54
Lines 6034 6039 +5
==========================================
+ Hits 4859 4860 +1
- Misses 1175 1179 +4
☔ View full report in Codecov by Sentry. |
DaniPopes
force-pushed
the
simpler-loops
branch
from
7e13383
to
a5804db
Compare
prestwich
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ord for [T]foralgorithms::cmpSolution
PR Checklist